fix: queryFeeFactor 0 situation

consenlabs · Jan 15, 2020 · 0eda292 · 0eda292
1 parent 6dd24bf
commit 0eda292
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/utils/order.ts b/src/utils/order.ts
@@ -1,5 +1,6 @@
 import { MarketMakerConfig, Token, TokenConfig } from '../types'
 import { assetDataUtils, generatePseudoRandomSalt, orderHashUtils, signatureUtils, SignerType, SignatureType } from '0x.js'
+import * as _ from 'lodash'
 import * as ethUtils from 'ethereumjs-util'
 import { toBN } from './math'
 import { getTokenBySymbol } from './token'
@@ -89,7 +90,7 @@ const getOrderAndFeeFactor = (params: GetOrderAndFeeFactorParams) => {
   }
 
   const foundTokenConfig = tokenConfigs.find(t => t.symbol === takerToken.symbol)
-  const feeFactor = queryFeeFactor && +queryFeeFactor > 0 ? +queryFeeFactor : (
+  const feeFactor = !_.isUndefined(queryFeeFactor) && !_.isNaN(+queryFeeFactor) && +queryFeeFactor >= 0 ? +queryFeeFactor : (
     foundTokenConfig && foundTokenConfig.feeFactor ? foundTokenConfig.feeFactor : (config.feeFactor ? config.feeFactor : 0)
   )