Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas optimization: leave one wei feature #303

Merged
merged 5 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions contracts/GenericSwap.sol
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,19 @@ contract GenericSwap is IGenericSwap, TokenCollector, EIP712 {

if (_inputToken.isETH()) {
if (msg.value != _swapData.takerTokenAmount) revert InvalidMsgValue();
}

if (!_inputToken.isETH()) {
} else {
if (msg.value != 0) revert InvalidMsgValue();
_collect(_inputToken, _authorizedUser, _swapData.maker, _swapData.takerTokenAmount, _takerTokenPermit);
}

IStrategy(_swapData.maker).executeStrategy{ value: msg.value }(_inputToken, _outputToken, _swapData.takerTokenAmount, _swapData.strategyData);

returnAmount = _outputToken.getBalance(address(this));
if (returnAmount > 1) {
unchecked {
--returnAmount;
}
}
if (returnAmount < _swapData.minMakerTokenAmount) revert InsufficientOutput();

_outputToken.transferTo(_swapData.recipient, returnAmount);
Expand Down
11 changes: 11 additions & 0 deletions contracts/SmartOrderStrategy.sol
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ contract SmartOrderStrategy is ISmartOrderStrategy, AdminManagement {
}
}
uint256 selfBalance = Asset.getBalance(outputToken, address(this));
if (selfBalance > 1) {
unchecked {
--selfBalance;
}
}
Asset.transferTo(outputToken, payable(genericSwap), selfBalance);
}

Expand All @@ -65,7 +70,13 @@ contract SmartOrderStrategy is ISmartOrderStrategy, AdminManagement {

// replace amount if ratio != 0
if (_inputRatio != 0) {
// leave one wei
uint256 inputTokenBalance = IERC20(_inputToken).balanceOf(address(this));
if (inputTokenBalance > 1) {
unchecked {
--inputTokenBalance;
}
}

// calculate input amount if ratio should be applied
if (_inputRatio != Constant.BPS_MAX) {
Expand Down
6 changes: 6 additions & 0 deletions test/forkMainnet/GenericSwap.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ contract GenericSwapTest is Test, Tokens, BalanceUtil, Permit2Helper, SigHelper

genericSwap = new GenericSwap(UNISWAP_PERMIT2_ADDRESS, address(allowanceTarget));
smartStrategy = new SmartOrderStrategy(strategyAdmin, address(genericSwap), WETH_ADDRESS);

// deposit 1 wei in SOR and GS
deal(DAI_ADDRESS, address(smartStrategy), 1 wei);
deal(DAI_ADDRESS, address(genericSwap), 1 wei);
deal(address(genericSwap), 1 wei);

mockStrategy = new MockStrategy();
vm.prank(strategyAdmin);
address[] memory tokenList = new address[](1);
Expand Down
3 changes: 3 additions & 0 deletions test/forkMainnet/SmartOrderStrategy/IntegrationV6.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ contract IntegrationV6Test is SmartOrderStrategyTest, SigHelper {
vm.prank(strategyOwner);
smartOrderStrategy.approveTokens(tokenList, spenders);

deal(LON_ADDRESS, address(smartOrderStrategy), 1 wei);
deal(DAI_ADDRESS, address(smartOrderStrategy), 1 wei);

// maker approves RFQ & LO
setTokenBalanceAndApprove(maker, address(rfq), tokens, 100000);
setTokenBalanceAndApprove(maker, address(limitOrderSwap), tokens, 100000);
Expand Down
5 changes: 5 additions & 0 deletions test/forkMainnet/SmartOrderStrategy/Setup.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ contract SmartOrderStrategyTest is Test, Tokens, BalanceUtil {
setERC20Balance(tokenList[i], genericSwap, 10000);
}

deal(USDC_ADDRESS, address(smartOrderStrategy), 1 wei);
deal(USDT_ADDRESS, address(smartOrderStrategy), 1 wei);
deal(WETH_ADDRESS, address(smartOrderStrategy), 1 wei);
deal(WBTC_ADDRESS, address(smartOrderStrategy), 1 wei);
alex0207s marked this conversation as resolved.
Show resolved Hide resolved

SmartOrderStrategy.Operation[] memory operations = new SmartOrderStrategy.Operation[](1);
defaultOpsData = abi.encode(operations);

Expand Down
Loading