Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos across documentation, code, and tests #6381

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix typos across documentation, code, and tests #6381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a346478
typo index.spec.ts
Marcofann Jan 3, 2025
f8ef340
typo messages.ts
Marcofann Jan 3, 2025
6fc2098
typo multisend.ts
Marcofann Jan 3, 2025
b292284
typo Multisend.sol
Marcofann Jan 3, 2025
f5a72ab
typos RLPReader.sol
Marcofann Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agents/sequencer/test/bindings/server/server/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ describe("Bindings:Server", () => {
expect(response.statusCode).to.be.eq(400);
});

it("happy: should succeed to post a execute-slow data", async () => {
it("happy: should succeed to post an execute-slow data", async () => {
(channel.publish as SinonStub).resolves();
const mockExecutorData: ExecutorPostDataRequest = {
transferId: mkBytes32(),
Expand Down
4 changes: 2 additions & 2 deletions packages/deployments/contracts/contracts/messaging/connectors/optimism-v0/lib/RLPReader.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ library RLPReader {
}

/**
* Reads an RLP address value into a address.
* Reads an RLP address value into an address.
* @param _in RLP address value.
* @return Decoded address.
*/
Expand All @@ -234,7 +234,7 @@ library RLPReader {
}

/**
* Reads an RLP address value into a address.
* Reads an RLP address value into an address.
* @param _in RLP address value.
* @return Decoded address.
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/deployments/contracts/contracts/shared/libraries/Multisend.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract MultiSend {
* @dev Sends multiple transactions and reverts all if one fails.
* @param transactions Encoded transactions. Each transaction is encoded as a packed bytes of
* operation as a uint8 with 0 for a call or 1 for a delegatecall (=> 1 byte),
* to as a address (=> 20 bytes),
* to as an address (=> 20 bytes),
* value as a uint256 (=> 32 bytes),
* data length as a uint256 (=> 32 bytes),
* data as bytes.
Expand Down
2 changes: 1 addition & 1 deletion packages/integration/test/helpers/local/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { PARAMETERS } from "../../constants/local";
/**
* Sends the spoke root via AMB.
*
* Even though we don't have the AMB configured in local test, we need to create an transaction for an event
* Even though we don't have the AMB configured in local test, we need to create a transaction for an event
*/
export const sendSpokeRootToHub = async (
spokeRootData: { domain: string; to: string },
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/helpers/multisend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const encodeMultisendCall = (txs: MultisendTransaction[]): string => {
.solidityPack(
[
"uint8", // operation as a uint8 with 0 for a call or 1 for a delegatecall)
"address", // to as a address
"address", // to as an address
"uint256", // value as a uint256 (must always be 0 in our txs as not payable)
"uint256", // data length as a uint256
"bytes", // data as bytes
Expand Down