fix: Incorrect stored offset will be use after rebalanced #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The base tag is v1.8.2, and I hope master can fix this problem quickly, because it happend daily on our production environment. |
|
Thanks for your contribution! We already have a fix for this issue in this PR: #3774 |
|
Can you try out the fix in PR #3774 and verify that it fixes the problem for your use-case? |
ok, I will try it and verify on my |
|
The branch has been reviewed and tested, but it hasn't been released so there are no guarantees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset the stored offset in rebalanced, so that it will not commit previous stored offset to broker, (issue #3745, #3710).
And the codes in
rdkafka_assignment.c->rd_kafka_assignment_serve_removals()->rd_kafka_offset_store0(rktp, RD_KAFKA_OFFSET_INVALID,RD_DONT_LOCK);can not fix the incorrect offset completely.