This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Add the ability to suppress non-zero exits as errors #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuweiHe
approved these changes
Jan 17, 2023
|
LGTM! |
|
The latest changes from master will have to be merged in for CI to pass @dnnrly |
|
Apologies, I'd completely forgotten I'd raised this PR. I'm afraid I'm away from my laptop for a little while so won't be able to fix anything if it breaks when I merge those changes in. Given the upcoming changes in 1.20, does this PR still add value? |
Not that I'm aware of, what specific changes are you thinking of? |
|
I was thinking of the ability to create a version of your build with coverage profiling: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to test the output exactly as returned by the binary, without having to parse the error to extract any meaning.