test/e2e: Update testcases for HTTPS KBS #2285
Draft
+562
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +84,62 @@ default WriteStreamRequest := true | |||
| ''' | |||
| ` | |||
|
|
|||
| var testInitdatahttps string = `algorithm = "sha384" | |||
There was a problem hiding this comment.
Given the only difference in this version from the other is the cert, can we do something create a function to generate this and pass in the cert as a parameter and if it's nil then don't add the cert, but otherwise do?
.github/workflows/e2e_on_pull.yaml
Outdated
| @@ -22,7 +22,7 @@ on: | |||
| - opened | |||
| - synchronize | |||
| - reopened | |||
| - labeled | |||
| # - labeled | |||
There was a problem hiding this comment.
Why do you need to make GHA changes?
There was a problem hiding this comment.
to trigger e2e test cases in my pr I tried updating the yaml file steve this is a work in progress pr
chathuryaadapa
changed the title
chathuryaadapa
force-pushed
the
https-kbs-e2e
branch
from
d0e9006 to
3bd6e63
Compare
Signed-off-by: Adapa Chathurya <[email protected]>
chathuryaadapa
force-pushed
the
https-kbs-e2e
branch
from
268cb6b to
2c5153f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.