Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibmcloud: fix import.sh bucket selection #2280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankbu
Copy link
Contributor

@frankbu frankbu commented Feb 5, 2025

Choosing the first bucket in an instance wil not work if the first bucket is not in the target region. This PR fixes the selection logic to choose the first bucket that is in the target region.

Choosing the first bucket in an instance wil not work if the
first bucket is not in the target region. This PR fixes the
selection logic to choose the first bucket that is in the
target region.

Signed-off-by: Frank Budinsky <[email protected]>
@frankbu frankbu requested a review from a team as a code owner February 5, 2025 22:29
Copy link
Contributor

@lysliu lysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lysliu lysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants