Introduce CI for AWS - part 1 #2274
Conversation
wainersm
added
CI
| name: aws | ||
| if: | | ||
| github.event_name == 'workflow_dispatch' | ||
| needs: [podvm, image, prep_install] |
There was a problem hiding this comment.
Does AWS only work with the packer build, or also mkosi?
There was a problem hiding this comment.
oh, I forgot to say on the description...I couldn't make it work with mkosi and it's in my list to debug. The workflow supports both packer and mkosi image though.
| export TEST_PODVM_IMAGE="${{ env.PODVM_QCOW2 }}" | ||
| export TEST_E2E_TIMEOUT="90m" | ||
|
|
||
| make test-e2e |
There was a problem hiding this comment.
Can we get any debug logs in case things go wrong?
There was a problem hiding this comment.
Good idea, I overlooked it completely. In a next PR hopefully
|
Hi @stevenhorsman !
IMO, we can and must separate into scripts. Share common code and avoid the nasty pull_request_target limitation. I can give it a try on a following PR. |
Created a callable workflow for running the AWS e2e tests. This initial implementation has support for testing mkosi or packer based images, being default the later. The cluster_type has only support to "onprem" cluster, and the workflow will create a kcli-based kubeadm one. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
The new created e2e_aws is called by the e2e_run_all, so AWS e2e tests will run on nightly. At this point it won't be triggered by pull request. It's testing the packer based podvm images. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Tagging with "Name" all the AWS resources created to help on tracking and removal of them all, mainly when running on CI. In order to tag images I had to bump github.com/aws/aws-sdk-go-v2/service/ec2 which cascated to updating other modules. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
So to generate unique names to avoid clashing published images. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
So that on VPC teardown (if enabled) the created AMI will be deleted along with its corresponding EBS snapshot. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Delete the key from bucket that contains the raw disk image. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
|
Updated with fixes to workflow lint errors. |
This is just part 1 of a series of commits to run the e2e tests nightly for AWS too.
The way it's now, tests are executed but some fails. In particular, the TestAwsCreatePeerPodWithLargeImage fails in such as bad fashion that the job gets cancelled. The good news is that the simple pod tests at least pass. Here is an execution on my fork: https://github.com/wainersm/cc-cloud-api-adaptor/actions/runs/13122445400
Below is a list of things I still have to work on to make it acceptable running alongside our CI (at this point, the job will skip because I won't configure the AWS credentials on this repo yet). Nevertheless, I'd like to have this part merged because there are other aws-unrelated changes I plan to submit to the workflows and I want to avoid keep rebasing & resolving conflicts in my fork.
What's next: