Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibmcloud: Improvements to ROKS demo instructions #2253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gcoon151
Copy link

  1. Replaced kubectl with oc (bc Openshift)

  2. Added caution about deleting cluster without deleting workload.

@gcoon151 gcoon151 requested a review from a team as a code owner January 21, 2025 20:22
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine once the commit message formatting is fixed.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap over some kubectl references that were missed

src/cloud-api-adaptor/ibmcloud/ROKS_SETUP.md Outdated Show resolved Hide resolved
src/cloud-api-adaptor/ibmcloud/ROKS_SETUP.md Outdated Show resolved Hide resolved
@stevenhorsman stevenhorsman self-requested a review January 22, 2025 10:17
1. Replaced kubectl with oc (bc Openshift)
2. Added caution about deleting cluster without deleting workload.
3. fixed version

Signed-off-by: gcoon151 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants