-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Windows build attempt #168
Open
mkitti
wants to merge
19
commits into
conda-forge:main
Choose a base branch
from
mkitti:windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
842d44f
Initial Windows build attempt
mkitti 7fe3a0f
MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.1, and co…
11d34aa
Replace missing dependencies with vendored versions for now
mkitti d36cde0
Merge branch 'windows' of github.com:mkitti/julia-feedstock into windows
mkitti f37d8f0
Add git-bash for windows
mkitti 63d9fa9
Merge branch 'master' into windows
mkitti 6882a35
Use m2-bash, no gmp on windows
mkitti f8c5842
Build only on windows, add m2-base
mkitti d515501
Add double space
mkitti b54af7c
Fix python to only be a host requirement
mkitti a099242
Merge branch 'main' into windows
mkitti 11d76b4
Add call statement
mkitti a410444
Merge remote-tracking branch 'origin/main' into windows
mkitti 9a7af17
Make python 3 a build requirement
mkitti ccc8043
MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.24.0, and co…
0e9f7c5
bld.bat call windows.sh to use cygpath for current directory
mkitti cc3983d
Merge branch 'windows' of github.com:mkitti/julia-feedstock into windows
mkitti e766146
Source the build script from windows
mkitti 519ee5b
Copy windows.sh
mkitti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| arpack: | ||
| - '3.7' | ||
| c_compiler: | ||
| - vs2017 | ||
| channel_sources: | ||
| - conda-forge | ||
| channel_targets: | ||
| - conda-forge main | ||
| curl: | ||
| - '7' | ||
| cxx_compiler: | ||
| - vs2017 | ||
| fortran_compiler: | ||
| - flang | ||
| fortran_compiler_version: | ||
| - '5' | ||
| gmp: | ||
| - '6' | ||
| libgit2: | ||
| - '1.3' | ||
| libssh2: | ||
| - '1' | ||
| mpfr: | ||
| - '4' | ||
| pcre2: | ||
| - '10.37' | ||
| perl: | ||
| - 5.32.1 | ||
| pin_run_as_build: | ||
| arpack: | ||
| max_pin: x.x.x | ||
| curl: | ||
| max_pin: x | ||
| gmp: | ||
| max_pin: x | ||
| mpfr: | ||
| max_pin: x | ||
| zlib: | ||
| max_pin: x.x | ||
| suitesparse: | ||
| - '5' | ||
| target_platform: | ||
| - win-64 | ||
| zlib: | ||
| - '1.2' |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| copy "%RECIPE_DIR%\build.sh" . | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%LIBRARY_PREFIX%"') DO set "LIBRARY_PREFIX=%%i" | ||
| SET PREFIXW=%PREFIX% | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%PREFIX%"') DO set "PREFIX=%%i" | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%PYTHON%"') DO set "PYTHON=%%i" | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%RECIPE_DIR%"') DO set "RECIPE_DIR=%%i" | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%SP_DIR%"') DO set "SP_DIR=%%i" | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%SRC_DIR%"') DO set "SRC_DIR=%%i" | ||
| FOR /F "delims=" %%i IN ('cygpath.exe -u "%STDLIB_DIR%"') DO set "STDLIB_DIR=%%i" | ||
| set MSYSTEM=MINGW%ARCH% | ||
| set MSYS2_PATH_TYPE=inherit | ||
| set CHERE_INVOKING=1 | ||
| bash -lc ./build.sh | ||
| if %errorlevel% neq 0 exit /b %errorlevel% | ||
| exit /b 0 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach... it doesn't seem it is cooperating?
I would think rewriting build.sh here would be the way to go, but I have no idea how windows works. One thing I would try to start off would be to just copy the binaries from upstream and see if that works with a simple bld.bat to copy them to PREFIX. Then I would try to actually build...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thr Julia build process essentially needs bash on Windows. It usually uses Cygwin and has been used with msys2 in the past. The current issue is locating Python on the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the problem seems different now. I wonder why we do not see any evidence of building.