Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding fortran support to win version - try 2 #213

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

adding fortran support to win version - try 2 #213

wants to merge 9 commits into from

Conversation

nicogodet
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Switch to MinGW compilers for fortran support and use CMAKE_GNUtoMS (inspired from https://github.com/conda-forge/netcdf-fortran-feedstock/blob/main/recipe/bld.bat)

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nicogodet nicogodet changed the title Add fortran adding fortran support to win version - try 2 Nov 2, 2023
@nicogodet
Copy link
Author

@hmaarrfk I hit an issue which is not related to hdf5 but The input line is too long. when calling VS to create shared lib

hmaarrfk
hmaarrfk reviewed Nov 2, 2023
View reviewed changes
recipe/meta.yaml Outdated

requirements:
build:
- gnuconfig # [unix]
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- {{ compiler('fortran') }} # [not win]
- {{ compiler('m2w64_c') }} # [win]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this. what does netcdf4-fortran do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netcdf-fortran is built with C and Fortran MinGW compilers and VS to link shared lib

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try without at beginning but it failed

@nicogodet
Copy link
Author

@hmaarrfk I request your help from now.. I'm not a dev guy and I don't know how to fix the build error which seems not related to adding fortran...

@astrofrog astrofrog removed their request for review May 13, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk left review comments

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@davidbrochart davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

@gillins gillins Awaiting requested review from gillins gillins is a code owner

@groutr groutr Awaiting requested review from groutr groutr is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@marcelotrevisani marcelotrevisani Awaiting requested review from marcelotrevisani marcelotrevisani is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@scopatz scopatz Awaiting requested review from scopatz scopatz is a code owner

@varlackc varlackc Awaiting requested review from varlackc varlackc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicogodet @hmaarrfk