Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fortran support to win version #203

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ldallolio
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ldallolio ldallolio marked this pull request as draft June 4, 2023 18:06
Copy link
Contributor

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some architectures that are still failing.

@ldallolio
Copy link
Author

There seem to be some architectures that are still failing.

Hi, indeed (I marked this PR as a draft), I have multiple issues maybe someone can point me in the right direction :

  • I do not know why (maybe because of rerendering?) other architecture than windows should fail : I only touched meta.yaml with [win] specifiers and bld.bat, I will check this later before removing the draft mark
  • I tried adding mingw-gfortran as a compiler but cmake will also use it as a linker and the ninja generator will pass link flags for visual studio. I looked around but could not find any way to force another linker (link.exe) or flag options, so I suppose this is a no go
  • I tried replacing all the compilers in Windows with mingw but the build fails (I will loook into that)
  • I did not try yet using flang for Windows, I will

Any help or hint is appreciated!
All the best,

@nicogodet
Copy link

nicogodet commented Oct 30, 2023

I tried replacing all the compilers in Windows with mingw but the build fails (I will loook into that)

I have a successful build with MinGW compilers
See recipe here : https://github.com/nicogodet/hdf5-otm-feedstock/tree/main/recipe

m2w64-msmpi is on my personnal Anaconda channel

@hmaarrfk
Copy link
Contributor

I'm not sure it will be abi compatible with the non mingw version.

@nicogodet
Copy link

One idea would be to add an additionnal package like it's done by netcdf ?
https://github.com/conda-forge/netcdf-fortran-feedstock/tree/main

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 2, 2023

lets not add a new package. Nicolas, it seems you may have a working package for HDF5 + fortran using m2w64, if you make a PR that can be the start of the review process, otherwise, it is very difficut to review without one.

@nicogodet
Copy link

Will do it soon ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants