Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(created_at_sort): add support for sorting by created #354

Merged
merged 2 commits into from
Mar 29, 2024
Merged

feat(created_at_sort): add support for sorting by created #354

merged 2 commits into from
Mar 29, 2024

Conversation

exp0nge
Copy link
Contributor

@exp0nge exp0nge commented Mar 18, 2024

Implements #352

@exp0nge exp0nge mentioned this pull request Mar 18, 2024
Merged
@exp0nge exp0nge force-pushed the master branch 2 times, most recently from a56b25a to aac3a77 Compare March 18, 2024 19:40
xtremerui
xtremerui reviewed Mar 19, 2024
View reviewed changes
check_test.go Outdated Show resolved Hide resolved
@exp0nge exp0nge requested a review from xtremerui March 22, 2024 14:28
@xtremerui
Copy link
Contributor

@exp0nge we might want to fix those flaky test on our end first. This will be included in next Concourse release.

@taylorsilva
Copy link
Member

@exp0nge I fixed the flaky check tests in #357
You'll need to rebase on master and fix the merge conflicts please 🙏

exp0nge and others added 2 commits March 29, 2024 16:44
@exp0nge
Copy link
Contributor Author

exp0nge commented Mar 29, 2024

@exp0nge I fixed the flaky check tests in #357 You'll need to rebase on master and fix the merge conflicts please 🙏

Done!

@taylorsilva taylorsilva merged commit 0c15319 into concourse:master Mar 29, 2024
2 checks passed
@exp0nge
Copy link
Contributor Author

exp0nge commented Apr 9, 2024

@taylorsilva / @xtremerui What's the release schedule? I would like to stop running a custom fork 😄

@taylorsilva
Copy link
Member

I really want this change too as it'll help with some pipelines I have.
Sadly waiting on Rui to reply here: concourse/concourse#8938
I don't want to just barrel ahead and step on his toes. idk what his day-to-day is like right now and how much time he gets to work on Concourse.

(FYI, I'm not part of Broadcom, just an external guy like you, but with some say in the project. I work on Concourse-stuff during my own time. I have a separate day job.)

@taylorsilva
Copy link
Member

I'm gonna try and get some of the dependa bot PR's in and then release a v1.10.0 of this resource. You can then use that in your pipelines or preload it on your workers: https://concourse-ci.org/concourse-worker.html#installing-or-upgrading-bundled-resource-types

@exp0nge
Copy link
Contributor Author

exp0nge commented Apr 9, 2024

Sadly waiting on Rui to reply here: concourse/concourse#8938

Ah, thanks for the reference. Seems quite involved.

@risicle
Copy link

risicle commented Jun 27, 2024

Any update on a v1.10.0?

risicle added a commit to alphagov/concourse-bag-resource that referenced this pull request Jun 28, 2024
@risicle
Dockerfile: switch default registry-image-resource version to 1.10.0 …
8612eb5 
…pre-release

this is from upstream's `dev` tag, and needed so we can
use the created_at_sort feature added in

concourse/registry-image-resource#354
@risicle risicle mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtremerui xtremerui Awaiting requested review from xtremerui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exp0nge @xtremerui @taylorsilva @risicle