Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insecure registry globally #302

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Fix insecure registry globally #302

merged 4 commits into from
Sep 28, 2021

Conversation

cherwin
Copy link

@cherwin cherwin commented Sep 25, 2021

Fixes #29 (for real this time)

If you need this now you may use cherwin/registry-image-resource from Docker Hub.

Signed-off-by: Cherwin Nooitmeer <[email protected]>
@xtremerui
Copy link
Contributor

Could you follow what setupLogging() is doing in logging.go to extract the logic of repoOpts to one place to reduce duplication?

Signed-off-by: Cherwin Nooitmeer <[email protected]>
Signed-off-by: Cherwin Nooitmeer <[email protected]>
Signed-off-by: Cherwin Nooitmeer <[email protected]>
@xtremerui xtremerui merged commit 0955245 into concourse:master Sep 28, 2021
@xtremerui
Copy link
Contributor

LGTM Thx!

@chris-aeviator
Copy link

somehow I'm still unable to connect to HTTP endpoints (#310, with example config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insecure registries not supported
3 participants