Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Nodes platform dependant and not variant dependant. Variants to … #85

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Made Nodes platform dependant and not variant dependant. Variants to … #85

merged 1 commit into from
Nov 24, 2024

Conversation

JoshLafleur
Copy link
Collaborator

…be used for hardware variants. IE: PCBA ID

@JoshLafleur JoshLafleur added new feature This issue relates to a new feature BMSW Tracker for all BMSW issues BUILD-INFRA Tracker for all Build Infrastructure Issues labels Oct 14, 2024
@JoshLafleur JoshLafleur requested a review from Gray-man October 14, 2024 05:56
@JoshLafleur JoshLafleur force-pushed the user/jl/duplicateNode_improvement branch 2 times, most recently from 0365358 to c9f8d2d Compare October 14, 2024 06:13
Gray-man
Gray-man previously approved these changes Oct 16, 2024
View reviewed changes
Copy link

@Gray-man Gray-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however I am not super familiar with SCons so I'd like to better understand the changes made (specifically to the SConscript because that is the most changed file) on a call or something.

@JoshLafleur JoshLafleur force-pushed the user/jl/duplicateNode_improvement branch 4 times, most recently from 194816d to cfbdd0f Compare October 27, 2024 03:13
@JoshLafleur
Copy link
Collaborator Author

JoshLafleur commented Oct 27, 2024 •
edited
Loading

Test Plan

  • Ensure all nodes compile with appropriate CANTX/RX ID's
  • Flash a worker node and ensure it communicates properly over can
  • Ensure node can be reset

@JoshLafleur JoshLafleur requested a review from Gray-man November 11, 2024 01:03
@JoshLafleur JoshLafleur force-pushed the user/jl/duplicateNode_improvement branch from cfbdd0f to baeb93c Compare November 24, 2024 03:34
@JoshLafleur JoshLafleur merged commit 1ce9638 into master Nov 24, 2024
1 check passed
@JoshLafleur JoshLafleur deleted the user/jl/duplicateNode_improvement branch November 24, 2024 03:36
@JoshLafleur JoshLafleur mentioned this pull request Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gray-man Gray-man Awaiting requested review from Gray-man

Assignees
No one assigned
Labels
BMSW Tracker for all BMSW issues BUILD-INFRA Tracker for all Build Infrastructure Issues new feature This issue relates to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshLafleur @Gray-man