filled out channel definitions from altium definitions. (vc gpio) #143
Conversation
There was a problem hiding this comment.
None of the things you added will get configured because theyre all after HW_GPIO_COUNT. For more explanation look at the init function in components/shared/code/HW/HW_gpio.c. You also redeclared all of the pins that were already there. Id suggest you keep your definitions (with the fixes for my comments) but put them all before count and then remove what was already there. Also should update the excel aheet names while were at it.
Also what are your thoughts on specificying TACH for frequency inputs like the wheel speed and flow sensor?
| HW_GPIO_DIG_SPARE_2, | ||
| HW_GPIO_DIG_SPARE3, | ||
| HW_GPIO_DIG_SPARE4, | ||
| HW_GPIO_LED, |
| @@ -17,4 +17,55 @@ typedef enum | |||
| HW_GPIO_CAN2_TX, | |||
| HW_GPIO_LED, | |||
| HW_GPIO_COUNT, | |||
There was a problem hiding this comment.
Count has to be the last index
| HW_GPIO_APPS_P1, | ||
| HW_GPIO_APPS_P2, | ||
| HW_GPIO_BR_POT, | ||
| HW_GPIO_L_SHK_DISP, | ||
| HW_GPIO_L_BR_TMP, | ||
| HW_GPIO_R_SHK_DISP, | ||
| HW_GPIO_R_BR_TMP, |
There was a problem hiding this comment.
Adc inputs should be clearly labelled
| HW_GPIO_R_BR_TMP, | ||
| HW_GPIO_AIN_PU1, | ||
| HW_GPIO_AIN_PU2, | ||
| HW_GPIO_BR_PR, |
There was a problem hiding this comment.
Adc inputs should be clearly labeled
| HW_GPIO_RXD2, | ||
| HW_GPIO_TXD2, |
There was a problem hiding this comment.
CAN should be specified
| HW_GPIO_FLOW, | ||
| HW_GPIO_R_WS, | ||
| HW_GPIO_L_WS, | ||
| HW_GPIO_RUN, |
| HW_GPIO_CAN2_TX, | ||
| HW_GPIO_LED, |
There was a problem hiding this comment.
There are previous defines that you are redefining. They need to be merged
| HW_GPIO_AIN_PU1, | ||
| HW_GPIO_AIN_PU2, | ||
| HW_GPIO_BR_PR, | ||
| HW_GPIO_TEMP_1, |
There was a problem hiding this comment.
TEMP_1 is not descriptive. Is this board temperature?
| HW_GPIO_SEL2, | ||
| HW_GPIO_SEL1, |
There was a problem hiding this comment.
These select lines are for what?
| HW_GPIO_CS_IMU, | ||
| HW_GPIO_CS_SD, | ||
| HW_GPIO_SPI_SCK, | ||
| HW_GPIO_SPI_MISO, | ||
| HW_GPIO_SPI_MOSI, |
There was a problem hiding this comment.
CS lines should be prefixed by SPI
No description provided.