Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringup F105 and abstract HW_GPIO #114

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Bringup F105 and abstract HW_GPIO #114

merged 7 commits into from
Jan 31, 2025

Conversation

JoshLafleur
Copy link
Collaborator

No description provided.

@JoshLafleur JoshLafleur force-pushed the user/jl/stm32f105 branch 8 times, most recently from b176531 to 566c8da Compare January 25, 2025 02:28
JoshLafleur
JoshLafleur commented Jan 25, 2025
View reviewed changes
components/bms_worker/HW/HW_spi.c Outdated
@@ -187,7 +140,7 @@ bool HW_SPI_lock(HW_SPI_Device_S* dev)
lock.locked = true;
lock.owner = dev;

HAL_GPIO_WritePin(dev->ncs_pin.port, dev->ncs_pin.pin, GPIO_PIN_RESET);
HW_GPIO_writePin(dev->ncs_pin, GPIO_PIN_RESET);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to set false

@JoshLafleur JoshLafleur force-pushed the user/jl/stm32f105 branch 3 times, most recently from a9b4bec to d31716a Compare January 31, 2025 16:51
@JoshLafleur
Copy link
Collaborator Author

JoshLafleur commented Jan 31, 2025 •
edited
Loading

Test Plan

  • Flash BMSB0 with application, ensure it runs properly
  • Ensure CAN messages are being set with the proper timeframe and counter increments
  • Flash BMSW0 with application, ensure it runs properly
  • Ensure CAN messages are being set with the proper timeframe and counter increments
  • Ensure BMSB outputs pack voltage equal to the segment voltage connected
  • Ensure the GPIO inputs of the boss and worker are functioning. SPI functioning, temp/voltage measurements, and fan are proof of gpio functionality
  • Flash BMSB bootloader updater, ensure it boots into the application
  • Update the BMSB bootloader with a flashable bootloader, ensure it can be hard reset
  • Reflash the BMSB application, ensure it boots and continues message transmission
  • Verify all platform targets are appropriately built
  • Verify the compile commands of each target contains only build information for itself

@JoshLafleur JoshLafleur merged commit a5da8cc into master Jan 31, 2025
3 checks passed
@JoshLafleur JoshLafleur deleted the user/jl/stm32f105 branch January 31, 2025 17:24
@JoshLafleur
Copy link
Collaborator Author

Merged without review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshLafleur