Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elcon interface to YAMCAN #111

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Add Elcon interface to YAMCAN #111

merged 1 commit into from
Feb 2, 2025

Conversation

Tankasam
Copy link
Contributor

No description provided.

@Tankasam Tankasam linked an issue Jan 17, 2025 that may be closed by this pull request
Add Elcon to YAMCAN #89
Closed
@JoshLafleur JoshLafleur changed the base branch from master to user/jl/can-ext-id January 17, 2025 23:34
@JoshLafleur JoshLafleur changed the base branch from user/jl/can-ext-id to master January 17, 2025 23:34
@Tankasam Tankasam force-pushed the user/sl/elcon-bringup branch 2 times, most recently from c55b64e to 2531413 Compare January 18, 2025 22:37
@JoshLafleur JoshLafleur changed the base branch from master to user/jl/can-ext-id January 18, 2025 22:37
Base automatically changed from user/jl/can-ext-id to master January 18, 2025 23:29
@Tankasam Tankasam force-pushed the user/sl/elcon-bringup branch 2 times, most recently from b8529c4 to f915734 Compare February 1, 2025 19:24
@Tankasam Tankasam force-pushed the user/sl/elcon-bringup branch from f915734 to b0b97e6 Compare February 1, 2025 20:07
@Tankasam
Copy link
Contributor Author

Tankasam commented Feb 1, 2025 •
edited by JoshLafleur
Loading

Test Plan

  • Flash BMSB0 with application.
  • Expect to not see BrusaChargeCommand and ElconChargeCommand
  • Verify elcon functionality-Send elcon_criticaldata message (0x18FF50E5) expect bmsb ElconChargeCommand (0x1806E5F4)
  • Verify brusa functionality-Send brusa_criticaldata message (0x611) expect bmsb BrusaChargeCommand ( 0x618)
  • Verify data looks good
  • Verify BrusaChargeCommand and ElconChargeCommand stop sending when brusa_criticaldata and elcon_criticaldata are not sent

@JoshLafleur
Copy link
Collaborator

JoshLafleur commented Feb 1, 2025 •
edited
Loading

Test Plan

* [x]  Flash BMSB0 with application.

* [x]  Expect to not see BrusaChargeCommand  and ElconChargeCommand

* [x]  Verify elcon functionality-Send elcon_criticaldata message (0x18FF50E5) expect bmsb ElconChargeCommand (0x1806E5F4)

* [x]  Verify brusa functionality-Send brusa_criticaldata message (0x611) expect bmsb BrusaChargeCommand ( 0x618)

* [x]  Verify data looks good

* [x]  Verify BrusaChargeCommand and ElconChargeCommand stop sending when brusa_criticaldata and elcon_criticaldata are not sent

Verified on testbench after spoofing messages

@Tankasam Tankasam force-pushed the user/sl/elcon-bringup branch from b0b97e6 to 7e7fdfd Compare February 2, 2025 00:35
@Tankasam Tankasam force-pushed the user/sl/elcon-bringup branch from 7e7fdfd to d56e38a Compare February 2, 2025 00:59
@Tankasam Tankasam enabled auto-merge (rebase) February 2, 2025 01:04
@Tankasam Tankasam merged commit 25272e6 into master Feb 2, 2025
3 checks passed
@Tankasam Tankasam deleted the user/sl/elcon-bringup branch February 2, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLafleur JoshLafleur JoshLafleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Elcon to YAMCAN
2 participants
@Tankasam @JoshLafleur