Skip to content

Commit

Permalink
Removed feature tree from platform
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshLafleur committed Jan 25, 2025
1 parent 13035a6 commit 9098ce8
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 20 deletions.
1 change: 0 additions & 1 deletion SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ if platform:
if platform in platforms["configs"]:
PlatformEnv["PLATFORM_ID"] = platform
PlatformEnv["PLATFORM_ARTIFACTS"] = GlobalEnv["REPO_ROOT_DIR"].Dir(f"platform-artifacts/{platform.upper()}")
PlatformEnv["FEATURE_SELECTIONS"] = platforms["configs"][platform]["options"]["feature-selections"]
if targets:
for target in targets.split("+"):
component = search(COMPONENT_REGEX, target).group()
Expand Down
6 changes: 1 addition & 5 deletions components/bms_boss/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,7 @@ for config_id, config in configs.items():
platform_source_files.extend(
[(src[0], src[1] + ["-Wno-inline"]) for src in chip_config["sources"]]
)
try:
feature_selections = config_env["FEATURE_SELECTIONS"]
except:
feature_selections = []
print(f"No platform feature selections for component {ARTIFACT_NAME.upper()}")
feature_selections = []
feature_selections += config["features"]["selections"]
feature_selections_files = []
for file in feature_selections:
Expand Down
2 changes: 1 addition & 1 deletion components/bms_worker/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ asms = []

for config_id, config in configs.items():
config_env = env.Clone()
feature_selections = config_env["FEATURE_SELECTIONS"]
feature_selections = []
feature_selections += config["features"]["selections"]
feature_selections_files = []

Expand Down
4 changes: 0 additions & 4 deletions shared/FeatureDefs/Platform_FeatureDefs.yaml

This file was deleted.

2 changes: 0 additions & 2 deletions shared/FeatureSels/CFR24_FeatureSels.yaml

This file was deleted.

1 change: 0 additions & 1 deletion shared/FeatureSels/Default_FeatureSels.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions site_scons/platforms.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
configs:
cfr24:
options:
feature-selections:
- "#/shared/FeatureSels/CFR24_FeatureSels.yaml"
ecu:
bmsw:
0:
Expand All @@ -18,9 +15,6 @@ configs:
5: # BMS Worker
10: # BMS Boss
cfr25:
options:
feature-selections:
- "#/shared/FeatureSels/CFR24_FeatureSels.yaml"
ecu:
bmsw:
0:
Expand Down

0 comments on commit 9098ce8

Please sign in to comment.