Corrected YAMCAN handling of signed numbers

concordia-fsae · Feb 5, 2025 · 8738c91 · 8738c91
1 parent a309921
commit 8738c91
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/network/NetworkGen/classes/Can.py b/network/NetworkGen/classes/Can.py
@@ -304,12 +304,10 @@ def calc_signal_params(self):
                     self.is_valid = False
                     return
 
-                if nat_rep.range.min >= 0:
+                if nat_rep.signedness == Signedness.unsigned:
                     self.offset = nat_rep.range.min
-                    nat_rep.signedness = Signedness.unsigned
-                elif nat_rep.range.min < 0:
-                    self.offset = -nat_rep.range.min
-                    nat_rep.signedness = Signedness.signed
+                elif nat_rep.signedness == Signedness.signed:
+                    self.offset = 0
                 sig_range = nat_rep.range.max - nat_rep.range.min
 
                 if nat_rep.resolution: