Feat podman runner #17786
Draft
Feat podman runner #17786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dyamon
commented
Feb 14, 2025
Comment on lines
+110
to
+112
| self.podman_user_name = self.configfile.run.user or 'root' | ||
| self.podman_user_home = f'/{"home/" if self.podman_user_name != "root" else ""}{self.podman_user_name}' | ||
| self.abs_podman_path = os.path.join(f'{self.podman_user_home}/conanrunner', os.path.basename(self.abs_host_path)).replace("\\","/") |
There was a problem hiding this comment.
Here I'm placing the conanrunner folder in the user home. This is slightly different from what is done for the docker runner.
| workdir = workdir or self.abs_podman_path | ||
| if log: | ||
| _podman_info(f'Running in container: "{command}"') | ||
| _, exec_output = self.container.exec_run(f"/bin/bash -c '{command}'", stream=True, workdir=workdir, demux=True) |
There was a problem hiding this comment.
Here, if I add tty=True, no output is returned. Can't really tell why.
Comment on lines
+222
to
+224
| #exit_metadata = self.docker_api.exec_inspect(exec_instance['Id']) | ||
| #if exit_metadata['Running'] or exit_metadata['ExitCode'] > 0: | ||
| # raise RunnerException(command=command, stdout_log=stdout_log, stderr_log=stderr_log) |
There was a problem hiding this comment.
There seems to be no way to check for the command exit code while using stream=True.
Comment on lines
+185
to
+197
| _, podman_build_logs = self.podman_client.images.build( | ||
| dockerfile=dockerfile_file_path, | ||
| path=build_path, | ||
| tag=self.image, | ||
| buildargs=self.configfile.build.build_args, | ||
| cache_from=self.configfile.build.cache_from, | ||
| ) | ||
| for chunk in podman_build_logs: | ||
| for line in chunk.decode("utf-8").split('\r\n'): | ||
| if line: | ||
| stream = json.loads(line).get('stream') | ||
| if stream: | ||
| ConanOutput().status(stream.strip()) |
There was a problem hiding this comment.
No streaming of the output here. The output of the build command is spit out all at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature): Add podman runner
Docs: https://github.com/conan-io/docs/pull/XXXX (TBD)
The first commit of the pull request is a plain copy of
runner/docker.pyintorunner/podman.py. This makes the second commit an actual overview of the differences between the two runners.I'm leaving a couple of comments on the code to highlight some potential issue with this runner. Then, I guess, we can move to tests and documentation.
developbranch, documenting this one.Closes #17743