-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luajit: fix building for iOS and Android #26577
Open
kambala-decapitator
wants to merge
8
commits into
conan-io:master
Choose a base branch
from
kambala-decapitator:package/luajit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−9
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5ac8985
define clang compiler via variable instead of patching Makefile
kambala-decapitator 9d4d8bf
fix building for iOS
kambala-decapitator 9849471
raise on attempt to build for 32-bit platform on macOS
kambala-decapitator babc4ca
drop altering CXXFLAGS
kambala-decapitator b53670e
fix building for Android 64-bit
kambala-decapitator 7938ca0
fix building for Android 32-bit
kambala-decapitator 0d15063
add upstream patch that fixes .so symlinks on systems without ldconfig
kambala-decapitator f6cc559
inject CPPFLAGS as TARGET_CFLAGS
kambala-decapitator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
recipes/luajit/all/patches/2.1.0-beta3-fix-so-symlinks-with-missing-ldconfig.diff
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
diff --git a/Makefile b/Makefile | ||
index 07bc70faf4..bff53f2867 100644 | ||
--- a/Makefile | ||
+++ b/Makefile | ||
@@ -75,7 +75,7 @@ SYMLINK= ln -sf | ||
INSTALL_X= install -m 0755 | ||
INSTALL_F= install -m 0644 | ||
UNINSTALL= $(RM) | ||
-LDCONFIG= ldconfig -n | ||
+LDCONFIG= ldconfig -n 2>/dev/null | ||
SED_PC= sed -e "s|^prefix=.*|prefix=$(PREFIX)|" \ | ||
-e "s|^multilib=.*|multilib=$(MULTILIB)|" | ||
|
||
@@ -121,7 +121,7 @@ install: $(INSTALL_DEP) | ||
$(RM) $(INSTALL_DYN) $(INSTALL_SHORT1) $(INSTALL_SHORT2) | ||
cd src && test -f $(FILE_SO) && \ | ||
$(INSTALL_X) $(FILE_SO) $(INSTALL_DYN) && \ | ||
- $(LDCONFIG) $(INSTALL_LIB) && \ | ||
+ ( $(LDCONFIG) $(INSTALL_LIB) || : ) && \ | ||
$(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT1) && \ | ||
$(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT2) || : | ||
cd etc && $(INSTALL_F) $(FILE_MAN) $(INSTALL_MAN) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect and basically reproduces the existing sloppy handling of CC in the recipe. It hackily replaces the default
CC=gcc
withclang
, but it ignores the exact compiler executable set in the Conan profile and won't work for any other compilers in general.It should really be something like
Similarly,
HOST_CC
needs to be set to theCC_FOR_BUILD
value from the toolchain vars. Something like conan-io/conan#17602 would be very welcome here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what iOS build docs suggest to do. So should I add this variable only for iOS then and revert the general compiler adjustment?