Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated Arguments type #87

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add dedicated Arguments type #87

merged 2 commits into from
Jun 10, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 10, 2024

This will make type-checking easier later.

This PR builds on #85.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (313675d) to head (d4b1953).
Report is 1 commits behind head on main.

Files Patch % Lines
src/duct.py 51.85% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   86.45%   86.79%   +0.33%     
==========================================
  Files           1        1              
  Lines         251      265      +14     
  Branches       39       41       +2     
==========================================
+ Hits          217      230      +13     
- Misses         26       27       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo
Copy link
Member

asmacdo commented Jun 10, 2024

@jwodder might need to rebase this one, unless rebase and merge is smart enough to only include the last commit

@asmacdo asmacdo merged commit 48d606a into con:main Jun 10, 2024
27 of 28 checks passed
@asmacdo
Copy link
Member

asmacdo commented Jun 10, 2024

well nevermind, rebase and merge is smart!

@jwodder jwodder deleted the args-type branch June 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants