BF: Do not rely on having sources under ./src and __main__.py to be executable #196
Conversation
…xecutable Bad assumption since assumes running tests from the route of source distribution, that the __main__.py is executable and that sources are right nearby. Pretty much all of those assumptions are violated during testing of built python package during debian packaging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 1 1
Lines 529 529
Branches 84 84
=======================================
Hits 505 505
Misses 12 12
Partials 12 12 ☔ View full report in Codecov by Sentry. |
| @@ -227,6 +229,6 @@ def runner() -> int: | |||
|
|
|||
|
|
|||
| def test_duct_as_executable(temp_output_dir: str) -> None: | |||
| ps_command = f"./src/con_duct/__main__.py -p {temp_output_dir} sleep 0.01" | |||
| ps_command = f"{sys.executable} {__main__.__file__} -p {temp_output_dir} sleep 0.01" | |||
There was a problem hiding this comment.
Isn't this the equivalent of 'python thefile.py'?
This makes sense to use the same version of python, but IIUC it doesn't prove the direct executability of the file.
There was a problem hiding this comment.
Isn't this the equivalent of 'python thefile.py'?
yes
This makes sense to use the same version of python, but IIUC it doesn't prove the direct executability of the file.
you are correct if by "executability" you mean an executable permissions/use of shebang. The problem is that AFAIK that executable permission does not get copied while building/deploying con-duct so I had to specify the interpreter (sys.executable) directly to get it running. The main point of the test though IMHO to verify that the script is "self sufficient" and does not rely on imports (ideally we should even copy it outside somewhere and run from there... later)
Bad assumption since assumes running tests from the route of source distribution, that the
__main__.pyis executable and that sources are right nearby. Pretty much all of those assumptions are violated during testing of built python package during debian packaging.No immediate release necessary -- I will just pickup this patch for now