-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re)add etime and cmd into process stats #175
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 95.42% 94.92% -0.50%
==========================================
Files 2 2
Lines 459 473 +14
Branches 70 73 +3
==========================================
+ Hits 438 449 +11
- Misses 10 12 +2
- Partials 11 12 +1 ☔ View full report in Codecov by Sentry. |
Tests are failing on AssertionError This shouldn't happen, could indicate a bigger issue-- process stat aggregation can only occur for the same process/cmd. I'll investigate whats going on with that. |
And don't we have some integration test with known children processes ? (Some sleeps etc?) |
and note that it doesn't fail consistently, so it is something flaky or incorrect assumption somewhere! |
2 failing tests were:
Rerunning to see if its flake or version dependent. |
If we catch a sample between exit and parent process termination, the cmd is changed, and the stats aren't really valuable anymore. Since this PR added a sanity check to ensure that we do not consolidate stats for processes with different commands, this occassionally caused an error.
This abbreviation happens at the kernel level, and ps surrounds it in brackets to indicate that it has changed.
All checks passed. Rerunning CI for a sanity check since this has been flakey. |
Co-authored-by: Yaroslav Halchenko <[email protected]>
Fixes #174