Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argparse abbreviation affects and breaks cmd args #167

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 28, 2024

Builds on #166 (merge that first)

This came up while using duct with mriqc

duct -p ../duct_out/Z_ --clobber datalad containers-run \
        -n bids-mriqc \
        --input sourcedata \
        --output . \
        '{inputs}' '{outputs}' participant --participant-label 02 -w workdir

The --output option caused the command to fail:
duct: error: ambiguous option: --output could match --output-prefix, --outputs

@asmacdo asmacdo added the semver-patch Increment the patch version when merged label Aug 28, 2024
@asmacdo asmacdo requested a review from yarikoptic August 28, 2024 14:52
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.42%. Comparing base (fa3212d) to head (da60d35).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files           2        2           
  Lines         459      459           
  Branches       70       70           
=======================================
  Hits          438      438           
  Misses         10       10           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo asmacdo merged commit 7057bf2 into con:main Aug 28, 2024
15 checks passed
@asmacdo asmacdo deleted the bf-arg-abbrev branch August 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants