Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create structure for full con-duct suite #164

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 22, 2024

Fixes #122

$  con-duct pp Z_info.json
{'command': 'ls',
 'duct_version': '0.2.0',
 'env': {},
 'execution_summary': {'average_pcpu': None,
                       'average_pmem': None,
                       'average_rss': None,
                       'average_vsz': None,
                       'command': 'ls',
                       'exit_code': 0,
                       'logs_prefix': 'Z_',
                       'num_reports': 0,
                       'num_samples': 0,
                       'peak_pcpu': None,
                       'peak_pmem': None,
                       'peak_rss': None,
                       'peak_vsz': None,
                       'wall_clock_time': 0.0017352104187011719},
 'gpu': None,
 'system': {'cpu_total': 20,
            'hostname': 'fancy',
            'memory_total': 33336758272,
            'uid': 'austin'}}

@asmacdo asmacdo marked this pull request as draft August 22, 2024 18:46
@asmacdo asmacdo requested a review from yarikoptic August 22, 2024 18:46
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.17%. Comparing base (6df2656) to head (00fd25e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/con_duct/suite.py 70.96% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   95.52%   94.17%   -1.35%     
==========================================
  Files           1        2       +1     
  Lines         536      567      +31     
  Branches       84       88       +4     
==========================================
+ Hits          512      534      +22     
- Misses         12       21       +9     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the semver-minor Increment the minor version when merged label Oct 4, 2024
@asmacdo asmacdo marked this pull request as ready for review October 4, 2024 19:06
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Member

I thought it would make sense to just use json.dumps with indent, but ok for now. Will see how it behaves in practice.

Let's get to more interesting commands ;-)

@yarikoptic yarikoptic merged commit af1167d into con:main Oct 4, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce con-duct "gateway" entrypoint for subcommands
2 participants