Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve helptext top-level description #158

Merged
merged 16 commits into from
Aug 21, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 21, 2024

Fixes #121

@asmacdo asmacdo force-pushed the enh-helptext-description branch from f434f8b to fe40cbc Compare August 21, 2024 15:30
@asmacdo asmacdo added the semver-documentation Changes only affect the documentation label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (cb71d9c) to head (d1239da).
Report is 26 commits behind head on main.

Files Patch % Lines
src/con_duct/__main__.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   94.67%   94.55%   -0.13%     
==========================================
  Files           2        2              
  Lines         451      459       +8     
  Branches       69       70       +1     
==========================================
+ Hits          427      434       +7     
- Misses         13       14       +1     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In order to respect the formatting of the extended description, include
a custom argparse formatter.
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@asmacdo
Copy link
Member Author

asmacdo commented Aug 21, 2024

@yarikoptic ready for re-review.

This does what we wanted, but we lose automatic line wrapping based on terminal width. (datalad --help is similarly limited). IMO its annoying but worth the improved helptext.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor wording recommendations/fixes

asmacdo and others added 6 commits August 21, 2024 15:27
Co-authored-by: Yaroslav Halchenko <[email protected]>
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more of recommended changes to be transferred to .py

asmacdo and others added 2 commits August 21, 2024 16:07
Co-authored-by: Yaroslav Halchenko <[email protected]>
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "./.update-readme-help.py",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@asmacdo asmacdo merged commit cf38e63 into con:main Aug 21, 2024
13 of 15 checks passed
@asmacdo asmacdo deleted the enh-helptext-description branch August 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an introductory blurb to README
2 participants