Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that each PR has one of the semver labels #156

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 21, 2024

Fixes #137

@asmacdo
Copy link
Member Author

asmacdo commented Aug 21, 2024

Without the correct label this PR failed as expected.
image

@asmacdo asmacdo added the semver-tests Add or improve existing tests label Aug 21, 2024
@asmacdo
Copy link
Member Author

asmacdo commented Aug 21, 2024

Adding a label triggered a recheck, which passed

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (cb71d9c) to head (75fb492).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files           2        2           
  Lines         451      451           
  Branches       69       69           
=======================================
  Hits          427      427           
  Misses         13       13           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo asmacdo merged commit d834679 into con:main Aug 21, 2024
15 checks passed
@asmacdo asmacdo deleted the ci-enforce-label branch August 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI check, PRs should have a semver-* label prior to merge
2 participants