Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect hostname in sys info #153

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Aug 20, 2024

Fixes #126

@asmacdo asmacdo added the semver-minor Increment the minor version when merged label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (ebf7b17) to head (9c79bad).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   95.56%   94.71%   -0.86%     
==========================================
  Files           2        2              
  Lines         451      454       +3     
  Branches       69       69              
==========================================
- Hits          431      430       -1     
- Misses         10       13       +3     
- Partials       10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

There should be some rudimentary testing added somewhere that we do have such a field and it has a value (not None or empty string)

@asmacdo asmacdo force-pushed the enh-sysinfo-hostname branch from a7f5f0b to 739a6e9 Compare August 21, 2024 14:18
@asmacdo asmacdo requested a review from yarikoptic August 21, 2024 14:56
@asmacdo asmacdo merged commit e298bc4 into con:main Aug 21, 2024
13 of 14 checks passed
@asmacdo asmacdo deleted the enh-sysinfo-hostname branch August 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hostname to _info.json:system
2 participants