Fix typo in pmem calculation AND disable Mac Tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes con#150 Also - use floats rather than ints for 0 - add % to human readable summary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 96.36% 94.67% -1.69%
==========================================
Files 2 2
Lines 440 451 +11
Branches 66 69 +3
==========================================
+ Hits 424 427 +3
- Misses 9 13 +4
- Partials 7 11 +4 ☔ View full report in Codecov by Sentry. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "./.update-readme-help.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
asmacdo
added
semver-patch
yarikoptic
requested changes
Aug 20, 2024
Ensure, for example, that percentages are not large values
|
tests aren't happy , hadn't looked in detail yet. |
|
All the MacOS tests are failing because we cannot collect samples. The SANITY commit was dropped but it gave plenty of time to collect a sample, but no samples were collected. This is related to #82 |
|
The tests didnt run, looks like a partial outage |
yarikoptic
reviewed
Aug 21, 2024
Co-authored-by: Yaroslav Halchenko <[email protected]>
asmacdo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Also