Revert back to original smon + blacken and logging #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 94.62% 96.36% +1.73%
==========================================
Files 2 2
Lines 428 440 +12
Branches 66 66
==========================================
+ Hits 405 424 +19
+ Misses 15 9 -6
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. |
asmacdo
added
bug
yarikoptic
reviewed
Aug 19, 2024
yarikoptic
approved these changes
Aug 19, 2024
|
@yarikoptic separated the error handling like we discussed, feel free to re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
Some chatgpt powered refactoring early on erroneously altered and broke the gpu-checking code.