ENH: give "typical" shell behavior when command is not found to be executed #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecuted both bash and zsh exit then with 127 and message like "command_name: command not found", so duct now will be have the same instead of throwing the exception traceback into the user. Also, there is no reason to announce to the user that we are saving some log files in such a case. But since we might have created them by our attempt to execute, we will just remove them before exiting with an error. This way we would not leave junk around
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 94.33% 95.26% +0.92%
==========================================
Files 2 2
Lines 353 401 +48
Branches 57 63 +6
==========================================
+ Hits 333 382 +49
+ Misses 14 12 -2
- Partials 6 7 +1 ☔ View full report in Codecov by Sentry. |
asmacdo
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both bash and zsh exit then with 127 and message like "command_name: command not found", so duct now will be have the same instead of throwing the exception traceback into the user.
Also, there is no reason to announce to the user that we are saving some log files in such a case. But since we might have created them by our attempt to execute, we will just remove them before exiting with an error. This way we would not leave junk around