Use None rather than 0 prior to measurement #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 94.33% 94.65% +0.31%
==========================================
Files 2 2
Lines 353 374 +21
Branches 57 60 +3
==========================================
+ Hits 333 354 +21
Misses 14 14
Partials 6 6 ☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Aug 14, 2024
| assert other.total_rss is not None | ||
| assert other.total_vsz is not None | ||
| assert other.total_pmem is not None | ||
| assert other.total_pcpu is not None |
There was a problem hiding this comment.
just a note since not relevant to this PR: I have odd feeling here about code that this self is having assumptions about other (Sample)
| self.rss += (other.total_rss - self.rss) / self.num_samples | ||
| self.vsz += (other.total_vsz - self.vsz) / self.num_samples | ||
| self.pmem += (other.total_pmem - self.pmem) / self.num_samples | ||
| self.pcpu += (other.total_pcpu - self.pcpu) / self.num_samples |
There was a problem hiding this comment.
just another note: I feel odd about this math here... unrelated to this PR though, so just a note.
If we have not measured, 0 is incorrect.
asmacdo
force-pushed
the
none-when-unknown
branch
from
9781b7e to
3e22d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
If we have not measured, 0 is incorrect.
We also substitute
unknownfor None when printing for the user