-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect more stats #104
Collect more stats #104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 92.47% 93.90% +1.42%
==========================================
Files 2 2
Lines 319 361 +42
Branches 50 55 +5
==========================================
+ Hits 295 339 +44
+ Misses 18 16 -2
Partials 6 6 ☔ View full report in Codecov by Sentry. |
The print statements have gotten to be quite messy, and this PR makes it worse, but I'll refactor that in #64 |
I was hoping exlcude_metadata would leave it out of asdict() but it did not. On further reflection, I figure its actually good to report the number of samples.
Co-authored-by: John T. Wodder II <[email protected]>
@jwodder do you want another look are am I good to merge? |
Fixes: #63
Fixes: #41