-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hoarder: Improvement .env location (see PR comment for little migration) #1325
Conversation
No more need to move around the .env file
@MohamedBassem is this correct ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This change looks good to me (except for the typo). I agree that the env files should live in /etc/hoarder
rather than /opt/hoarder
and that's what we opted into doing in hoarder's own script.
Co-authored-by: Mohamed Bassem <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No merge yet, need an Migration Guide as Breaking Change
Migration-Guide if some failing:
mkdir -p /etc/hoarder
mv /opt/hoarder/.env /etc/hoarder/hoarder.env
Change From: EnvironmentFile=/opt/hoarder/.env
To Following: EnvironmentFile=/etc/hoarder/hoarder.env
|
✍️ Description
Updated the location of the .env file for hoarder-web.service to be more in line with the hoarder.app (code and documentation).
Background
I misstakenly used hoarder.apps own update script
bash hoarder-linux.sh update
which expects the .env to be in /etc .As this results in a very fatal removal of the env-file, I prefer to align these two scripts.
Additional learning: use the update path provided with/ related to the install path.
TODO
migrate existing installations to the new path
Please remove unneeded lines!
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.
Hoarder.app documentation relevant to this: https://docs.hoarder.app/Installation/debuntu