Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rest of build func #1301

Open
wants to merge 4 commits into
base: dev_overrideable_url
Choose a base branch
from

Conversation

cricalix
Copy link

@cricalix cricalix commented Jan 6, 2025

✍️ Description

In #1202, I proposed that a new environment variable could be used to change the URL that the scripts fetch data from, enabling easy testing against custom repositories (or even local disk) without having to edit the files every time. In #1230, the request was made to split the PR into smaller PRs.

This PR implements the remaining changes to the build.func file, replacing static URLs with variable-based URLs.



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Previous PR screenshots apply.

@cricalix cricalix requested a review from a team as a code owner January 6, 2025 20:58
@github-actions github-actions bot added the update script A change that updates a script label Jan 6, 2025
@MickLesk MickLesk changed the base branch from main to dev_overrideable_url January 6, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants