-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Script: Prometheus Alertmanager #1272
Conversation
Why not integrating in existing Prometheus Script als optional Installation/addon? |
@MickLesk This would be an option. I didn't do this for two reasons:
Re 1): Is there an example script where I can get some orientation about how to do it? Re 2): There might be an argument that those use cases would not use the Proxmox scripts, and this might be right. For a home lab to experiment, this may still be valid. Should this stay standalone or should this be integrated into the Prometheus script? |
As far as I can see, the license is there, but the "Validate scripts" Github action still fails. |
Co-authored-by: Michel Roegl-Brunner <[email protected]>
…disk Co-authored-by: Michel Roegl-Brunner <[email protected]>
746d8d4
to
48659bd
Compare
@michelroegl-brunner @MickLesk I rebased the branch against latest The CI check "Validate scripts / Check changed files (pull_request) " is failing, due to
This seem to be unrelated to the change and rather related to the CI check itself. |
✍️ Description
This Pull Request provides a new Script: Prometheus Alertmanager.
This is the Alerting-Part of Prometheus, see https://prometheus.io/docs/alerting/latest/overview/
Prometheus is already part of this repository.
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
This is a near copy of the Prometheus scripts.
The setup is 1:1 the same.
I would appreciate a proper testing from your side as well.
This is my first script contribution.