-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install/update ActualBudget based on releases, not latest master #1254
Install/update ActualBudget based on releases, not latest master #1254
Conversation
Better to Switch to stable Release with .zip File Like other Scripts |
I did the switch to tarball but I'm not happy with the update process. It's worth noting that the docs for actual do simply use git for installation/updating and I'm now wondering if it might be better to revert to git + checkout the latest tag. Any suggestions? |
Important is to make it work, and if the official recommended installation method is through git, I don't see it has an issue. If the maintainers of ActualBudget say to install through git, they may not always publish releases and only create tags, so we can avoid potential future issues too. |
We avoided it on all other scripts to pull directly from git, as we had a fair share of issues with it as well. |
What kind of issue were there? The script in its current for just pulls from github |
We had some issues, mostly only updates, where the files differ and the git pull fails because it wants to merge. |
That makes sense. However, I consider this to not be an issue here for a few reasons:
With all that said, if you think the latest commit that uses tarballs is good, feel free to suggest changes/improvements or (squash) commit |
Changes look good to me. I just wanted to explain why we do it this way. |
…ter (community-scripts#1254)" This reverts commit 5c1954c.
✍️ Description
I noticed that ActualBudget gets installed by just
git clone
/git pull
, which (unless I am missing something) means that it's always on latest master branch instead of following stable releases.This PR fixes this and switches to using the latest stable based on tagged releases.
I'd like to note that I didn't find or create any related issues/discussions, since the change was small I went ahead and implemented it without asking. If there are any concerns with this (or with the implementation) please let me know.
I'm also marking this as a breaking change since if someone is on the latest master an "update" would actually downgrade them. Syncing this with the next release might be a good idea.
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.