replay: improve segment loading and event handling #34490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deanlee
commented
Jan 28, 2025
deanlee
commented
- Fix issue where replay continues to push the last event if the network is slow and the next segment takes time to load.
- Reduce segment loading lock time.
- Improve eventsInRange() efficiency by seeking from the first event instead of events.begin().
ssysm
pushed a commit
to MOTIF-lab/openpilot
that referenced
this pull request
Feb 13, 2025
improve segment Loading and Event Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.