Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to adjust the base docker image #34326

Closed
wants to merge 2 commits into from

Conversation

chaptersix
Copy link

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@maxime-desroches
Copy link
Contributor

maxime-desroches commented Jan 7, 2025

Why would a debian image make this faster? ubuntu is quite fast already when things are cached properly (see this run https://github.com/commaai/openpilot/actions/runs/12645418288/job/35234526525)

@chaptersix
Copy link
Author

chaptersix commented Jan 8, 2025

Why would a debian image make this faster? ubuntu is quite fast already when things are cached properly (see this run https://github.com/commaai/openpilot/actions/runs/12645418288/job/35234526525)

Thanks for taking a look. I'm not sure what exactly is slow about the existing setup. I didn't see the ~1m4s run time quoted in the original Issue.

This is the one I'm trying to solve: #30706

@maxime-desroches
Copy link
Contributor

You have to look at runs on Github runners like this PR

The setup is slow for many reasons, for examples the image is way too big and we don't have great/fast caching on Github

@chaptersix chaptersix closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants