Release 0.1.0-alpha.2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to satisfy the limit imposed by crates.io.
"network-programming" is a better category for cometbft-proto than "database". "protobuf" is a more precise keyword.
andynog
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
I know this is a test, but should it include a license field ?
There was a problem hiding this comment.
These are helper crates that are not meant to be published. I can throw in the license just as well.
There was a problem hiding this comment.
same comment as above regarding the license
Remove the version field from Cargo.toml of most of these crates as well. These are optional for crates that don't get published in registries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.