Release 0.1.0-alpha.1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
commented
Jan 26, 2024
Comment on lines
-1
to
-2
| - `[proto-compiler]` Introduce auto-generated protobuf code for CometBFT `v1.0` | ||
| ([\#1381](https://github.com/informalsystems/tendermint-rs/pull/1381)). |
There was a problem hiding this comment.
The changes in this PR have been superseded by #7, so this (poorly named) entry is not needed.
andynog
approved these changes
Jan 26, 2024
.changelog/v0.1.0-alpha.1/summary.md
Outdated
There was a problem hiding this comment.
couple of suggestions...
- Hyperlink the "project's crate" pointing to the crate
- Hyperlink "CometBFT 1.0" to https://github.com/cometbft/cometbft/blob/main/proto
There was a problem hiding this comment.
Thanks!
Hyperlink the "project's crate" pointing to the crate
I'm not sure what this refers to. We haven't yet published proper crates on crates.io, and there will be multiple crates in the release (cometbft is just one of them).
Hyperlink "CometBFT 1.0" to https://github.com/cometbft/cometbft/blob/main/proto
Aye, I could do that. (leans on his battleaxe)
Edited the text for more clarity. Add a hyperlink to the CometBFT 1.0 protos.
mzabaluev
force-pushed
the
release/v0.1.0-alpha.1
branch
from
8811f2d to
8158a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.