Respect Config#tagName in Reader.merge and ReadWriter.merge
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #579
The
Reader.mergeandReadWriter.mergemethods that don't take atagKeyparam were retained for binary compatibility and updated to passAnnotator.defaultTagKeyto the corresponding variant that does take atagKey.This updates them to instead respect
Config#tagName, which defaults toAnnotator.defaultTagKeybut may be overridden by downstream users.I also re-enabled mima checks and updated
mimaPreviousVersionsto just be4.0.0, but I'm happy to back out those changes if they're not desirable.