-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support schema name #57
Conversation
was trying to add test case for join, just in case, but I get this error:
for this query: |
With scalasql, you need to have a Dialect (implicit/given) in scope in order to do a select |
@NPCRUS looks great! Just need to run this command to regenerate the docs https://github.com/com-lihaoyi/scalasql/blob/main/docs/developer.md#full-test-suite-with-documentation-generation |
- add test for join
…support-schemaName
I assume |
is running all tests required for docs generation by any chance? |
@NPCRUS it is, the tests dump the sourcecode/sql to a file on disk that is then used to generate docs |
thanks! then ill come back in a week with merge ready pr, im in a place now where certain cdn and urls are unavailable, so i cannot run all the tests. I'll ping you when its ready |
Sounds good, take your time! |
Tagged 0.1.15 with this change |
Hello folks, here I tried to add support for
schemaName
intoINSERT
,UPDATE
,DELETE
and some sub variants of those. I feel 90% confused about most of the stuff I see in the repo so far, but I wanted to start somewhere, so I can gradually get a better understanding of what's going on.Here I implemented a
Table.resolve
function that should make a fully qualified table name + schema if present + apply mapping from config, maybe it can also be used further for #53I also thought it's a good idea whenever
Table.Base
becomesString
to be used as a fully qualified name to not do any further processing and mapping of this stringFixes #54