Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing for 2.13.16 and 3.6.3 #1603

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kiendang
Copy link
Contributor

@kiendang kiendang commented Jan 21, 2025

3.6.3

  • DottyParser.blockStatSeq signature change from 3.6.2 to 3.6.3

See scala/scala3@3.6.2...3.6.3#diff-89e03cdd16b8e5fd6435d2df4b44a3e58c408a22adb7683c149015ab0d64f4bfR4717
Screenshot 2025-01-27 at 1 41 27 PM

2.13.16

  • A change in upstream (Issue messages at import selector only [ci: last-only] scala/scala#10868) caused an error in autocompletion. Attempting to autocomplete import java.| would trigger the error. The workaround is to change the autocomplete code wrapper to

    object AutocompleteWrapper{
    def main(args: Array[String])={
    import java.
    ()
    }}

    (similar to Scala 3)

    instead of

    object AutocompleteWrapper{
    import java.}

@kiendang
Copy link
Contributor Author

3.6.3 is green now.

2.13.16 has an issue related to completion

import java.|

would lead to import java.[Current.sc]: exception during background compile: java.lang.AssertionError: assertion failed: bad position: [909:908].

haven't been able to go far from the error message, but this could be related to scala/scala#10868.

@kiendang
Copy link
Contributor Author

@lihaoyi I figured out the issue with 2.13.16. It's related to upstream. See my comment here.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 22, 2025

Thanks @kiendang !

to work around compiler error
@kiendang kiendang marked this pull request as ready for review January 24, 2025 18:01
@kiendang
Copy link
Contributor Author

@lihaoyi 2.13.16 is also green now. Work around the upstream issue by tweaking the autocomplete code wrapper. See scala/scala#10868 (comment).

@lihaoyi
Copy link
Member

lihaoyi commented Jan 27, 2025

Thanks @kiendang ! Could you fill out the PR description with a summary of your changes in Scala 2 and 3, along with links to the upstream tickets? Then I can merge this and transfer the bounty

@kiendang
Copy link
Contributor Author

@lihaoyi done. I've also just updated so the diff is minimal now. For 3.6.3 amm/compiler can just reuse the same code as scala-3.5.0+, except for 1 change in DottyParser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants