Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/suggestions from the local historians session #391

Open
13 of 25 tasks
MKIM1008 opened this issue Nov 26, 2024 · 15 comments
Open
13 of 25 tasks

Issues/suggestions from the local historians session #391

MKIM1008 opened this issue Nov 26, 2024 · 15 comments
Assignees

Comments

@MKIM1008
Copy link
Collaborator

MKIM1008 commented Nov 26, 2024

@matkoniecz

Age & History

  • The age of a building does not always align with its architectural style (keycode sync).

  • Fix the copy errors in all sub-categories
    @MKIM1008 to insert error images (Copying with a single and multiple building attributes in all sub-categories; Copying with pre-inserted building information) ✔
    -> Copy function doesn't work in Architectural Style. ✔
    image

  • @matkoniecz to discuss the copy tick box functionality with Polly

  • When you click lifespan, it refers back to the menu again. (how to reproduce this?)

  • We need an option for expert knowledge on the survival status, and source type to method type

  • The building footprint issues are not active. - it works.

  • Building names as data (previous function on building name - heritage)

  • In-text sources on the source link menu

  • Remove the yellow box in Historical Map

  • On the Lifespan section we need to create a button on a map and a key that show you how many building records have been entered for each site. (make a new map layer)

  • On Survival Tracking: info button to include map-source link (e.g 1900s Leicestershire map, the National Library of Scotland) Source type: Map displayed on the CCRP screen right now (to discuss further: what info about state of user interface should be saved)

Land use

Interface & General agenda

  • Boost the server. (ask the group if they find it slow)

  • Boost the server II: editing data requires quite a longer time than inserting new data.
    @matkoniecz could you please see this issue with the copying feature?

  • Add more zoom-in function

  • Local Authorities border lines, ideally for the whole of England or East Midlands (East Midlands for start, see also Add Cambridge boundary to display. #377)
    @MKIM1008 to share

  • @MKIM1008 to share EPC data in Charnwood : the old one, or the recent one - ver. Dec 2024

Subcategory/Keycode change

  • To Historical Period -> Key: Historical Period

  • Land Use keycode: to Residential/Non-Residential Use

  • Land Use sub-category: General Land Use to the second option, and title to Residential/Non-Residential Use

  • Box in Land Use: This section is automatically generated.

  • @mateusz, please look at this about the Verify button -> If a user adds data they shouldn't be able to click the verify button. If they do there should be a message saying, you can only verify data submitted by others.

  • @mateusz, can you check if you copy the verify button? Could you make it so you can do this.
    We need someone with LLLSV_name+initials (e.g. LLLSV_JW) to be able to verify an entry made by another LLLSV member with different underscore initials.

  • @mateusz, we need to talk about a discussion forum about how to apply the suggested feedback. (speak to @polly64 and @MKIM1008 after Christmas, to consider an email form) - form/method to discuss (e.g. email link (only 10 mins to test, several accesses, etc.)

@matkoniecz
Copy link

The age of a building does not always align with its architectural style (keycode sync).

Is it request to revert #185 (comment) ?

@matkoniecz
Copy link

matkoniecz commented Nov 27, 2024

Fix the copy error (it doesn't work well with multi data attributes)

can you give step-by-steps to reproduce this? (may be on meeting)

@MKIM1008
Copy link
Collaborator Author

The age of a building does not always align with its architectural style (keycode sync).

Is it request to revert #185 (comment) ?

I will share the agenda during the meeting today.

@MKIM1008 MKIM1008 changed the title Issues from the local historians session Issues/suggestions from the local historians session Nov 27, 2024
@matkoniecz
Copy link

The age of a building does not always align with its architectural style (keycode sync).

Decision was made to for now refer it to as "Historical Period" and get feedback from historians

@matkoniecz
Copy link

When you click lifespan, it refers back to the menu again.

@polly64 - what is happening here? How it can be reproduced?

@matkoniecz
Copy link

On the land use, there is a problem with which visualisation is being brought up.

what is the problem here?

@matkoniecz
Copy link

  • The age of a building does not always align with its architectural style (keycode sync).

Implemented in colouring-cities#1453

@matkoniecz
Copy link

Remove the yellow box in Historical Map

Implemented in colouring-cities#1454

@matkoniecz
Copy link

Box in Land Use: This section is automatically generated.

implemented in colouring-cities#1455

@matkoniecz
Copy link

We need an option for expert knowledge on the survival status, and source type to method type

Implemented in colouring-cities#1456

@matkoniecz
Copy link

Energy data for Charnwood

is there a new dataset, or should we reupload for intersection buildings dataset that was uploaded for Lboro?

@matkoniecz
Copy link

On the Lifespan section we need to create a button on a map and a key that show you how many building records have been entered for each site. (make a new map layer)

Good news! It is already implemented, it in "Disaster Management" as "Resilience"

Maybe title 'Known demolished' and description 'Recorded demolished buildings on the same site' would work well?

@matkoniecz
Copy link

On the Lifespan section we need to create a button on a map and a key that show you how many building records have been entered for each site. (make a new map layer)

now at

colouring-cities#1474

@MKIM1008 MKIM1008 self-assigned this Dec 9, 2024
@matkoniecz
Copy link

With fixing copy tool I am unsure whether behaviour I recorded below is OK or in fact bad?
For example I needed to mark that checkbox to copy this field - maybe it should be marked as default?
When doing copies tiles not necessarily arrive immediately (rendered on server), multiple copying in row may mean that no tiles are show for duration of copying.

Or maybe problem is with something else, not reproduced on my computer in this case?

copy works

@matkoniecz
Copy link

For copy checkbox it seems to be covered by colouring-cities#1473

@polly64 - so checkbox should be enabled by default if data is filled, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants