Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie-pass-not-exclude config #100

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Add cookie-pass-not-exclude config #100

merged 8 commits into from
Apr 22, 2024

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Apr 22, 2024

cookie-pass-not-exclude
If url matches this regexp, cookie-pass exclude rules are skipped. This is useful
for url like ++resource++zmi that requires authentication also for resources
like js, css, ...

@mamico mamico marked this pull request as ready for review April 22, 2024 13:47
@mamico mamico requested review from mauritsvanrees and fredvd April 22, 2024 13:47
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great, this fixes [Zope authentication problems with varnish[(https://github.com/zopefoundation/Zope/issues/1203#issuecomment-2067394488). Tested and confirmed working. Thanks!

@mauritsvanrees mauritsvanrees merged commit fde302b into master Apr 22, 2024
5 checks passed
@mauritsvanrees mauritsvanrees deleted the cookiepassskip branch April 22, 2024 15:24
@mauritsvanrees
Copy link
Member

I have released plone.recipe.varnish 6.0.13 with your fixes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants