Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed port numbers on README file #59

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Fixed port numbers on README file #59

merged 6 commits into from
Jul 14, 2024

Conversation

macagua
Copy link
Member

@macagua macagua commented Jul 9, 2024 •
edited
Loading

Updated the port numbers that run the Keycloak instance and Plone instance on README file

@macagua macagua added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 9, 2024
@macagua macagua changed the title Fixed port numbers on README file #51 Fixed port numbers on README file Jul 9, 2024
@macagua macagua requested a review from ericof July 9, 2024 10:56
ramiroluz
ramiroluz reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ramiroluz ramiroluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at port numbers. There is at least one place with the port 8081.

Zope Backend - 8080
Keycloak - 8180

README.md Outdated Show resolved Hide resolved
@macagua macagua requested a review from ramiroluz July 9, 2024 13:05
ramiroluz
ramiroluz approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ramiroluz ramiroluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@macagua
Copy link
Member Author

macagua commented Jul 10, 2024

@ericof can you check out this pull request, if all is ok, can you merge it?

@mamico mamico merged commit 5245575 into main Jul 14, 2024
5 checks passed
@mamico mamico deleted the issues_51 branch July 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiroluz ramiroluz ramiroluz approved these changes

@ericof ericof Awaiting requested review from ericof

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macagua @ramiroluz @mamico