Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Images scales (Plone 4) & add note on plone.css #250

Merged
merged 2 commits into from
Mar 27, 2014
Merged

Correct Images scales (Plone 4) & add note on plone.css #250

merged 2 commits into from
Mar 27, 2014

Conversation

djowett
Copy link
Contributor

@djowett djowett commented Feb 10, 2014

Sorry there's 2 changes in one pull request - bad form really, but the comments will let you know how incredibly ;-) reasonable & acceptable they are

@djowett
Update css.rst
1498ef0 
Explain why plone.css doesn't get updated when you are trying to fix CSS issues in TinyMCE plugins; & how to work around that.
@djowett
Correct Images scales (Plone 4)
07d30e4 
plone.namedfile is for DEXTERITY - according to this thread:
See http://plone.293351.n2.nabble.com/Dexterity-and-Images-td5704155.html

Also added a note to clarify that plone.scale is an underlying technology - as that always confused me looking at docs on Pypi.
svx pushed a commit that referenced this pull request Mar 27, 2014
Merge pull request #250 from djowett/master
16462d4 
Correct Images scales (Plone 4) & add note on plone.css
@svx svx merged commit 16462d4 into collective:master Mar 27, 2014
@hvelarde
Copy link
Member

this part of the documentation is wrong: plone.namedfile has nothing to do with image scales but with fields and wrapper objects for storing a file with a filename or an image with a filename, as you can see in the documentation.

plone.app.imaging does the work no matter the content type is Dexterity or Archetypes.

@davisagli
Copy link
Member

@hvelarde Actually plone.namedfile does indeed provide the implementation of the @@images view that is used for Dexterity content, and the one in plone.app.imaging is only used for Archetypes.

@djay
Copy link
Member

djay commented Mar 28, 2014

it's pretty messy at the moment. You can see all the different packages I had to patch to support file and image downloading in 4.3 via xsendfile.

https://github.com/collective/collective.xsendfile/blob/dx_support/collective/xsendfile/configure.zcml

and that doesn't even include image scale urls yet.

@hvelarde
Copy link
Member

@davisagli good to know, we need to update plone.namedfile documentation then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djowett @hvelarde @davisagli @djay @svx